Skip to content

Remove strip_pysb #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dweindl merged 1 commit into from
Nov 5, 2025
Merged

Remove strip_pysb #3014

dweindl merged 1 commit into from
Nov 5, 2025

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 4, 2025

Replace the remaining usages of strip_pysb after #3005.

Some were useless anyways.

Closes #3004.

@codecov
Copy link

codecov bot commented Nov 4, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.71%. Comparing base (2717020) to head (360d006).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
python/sdist/amici/import_utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3014       +/-   ##
===========================================
+ Coverage   48.72%   76.71%   +27.99%     
===========================================
  Files          53      309      +256     
  Lines        7239    19899    +12660     
  Branches        0     1497     +1497     
===========================================
+ Hits         3527    15265    +11738     
- Misses       3712     4621      +909     
- Partials        0       13       +13
Flag Coverage Δ
cpp 72.49% <66.66%> (?)
cpp_python 37.89% <66.66%> (?)
petab 38.52% <83.33%> (?)
petab_sciml 14.15% <33.33%> (?)
python 69.31% <66.66%> (+20.59%) ⬆️
sbmlsuite-jax 32.97% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/de_export.py 96.89% <100.00%> (+10.45%) ⬆️
python/sdist/amici/jax/ode_export.py 88.33% <ø> (+5.00%) ⬆️
python/sdist/amici/petab/pysb_import.py 61.76% <100.00%> (+61.76%) ⬆️
python/sdist/amici/import_utils.py 84.23% <50.00%> (+17.08%) ⬆️

... and 291 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl
Copy link
Member Author

dweindl commented Nov 4, 2025

FIXME: DEModel.syms may also contain non-sympy.Symbol. E.g. Zero in dtcldp.

@dweindl
Remove strip_pysb
360d006 
Replace the remaining usages of `strip_pysb` after AMICI-dev#3005.

Some were useless anyways.

Closes AMICI-dev#3004.
@dweindl dweindl self-assigned this Nov 4, 2025
@dweindl dweindl marked this pull request as ready for review November 4, 2025 14:12
@dweindl dweindl requested a review from a team as a code owner November 4, 2025 14:12
@dweindl dweindl merged commit 7f15329 into AMICI-dev:main Nov 5, 2025
28 checks passed
@dweindl dweindl deleted the remove_strip_pysb branch November 5, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FFroehlich FFroehlich FFroehlich approved these changes

Assignees

@dweindl dweindl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace strip_pysb calls

2 participants

@dweindl @FFroehlich